Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trafficrouting): apply stable selectors on canary service on rollout abort #2781 #2818

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix(trafficrouting): apply stable selectors on canary service on rollout abort #2781 #2818

merged 2 commits into from
Jul 11, 2023

Commits on Jun 29, 2023

  1. Re-apply stable to simple canary service on abort when no traffic rou… 

    …ting is used

fixes argoproj#2781

* remove redundant block of code

Signed-off-by: mitchell amihod <[email protected]>
    @meeech
    meeech committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    71076b6 View commit details
    Browse the repository at this point in the history

  2. Add an e2e covering the fix. 

    Basically a copy/pasta of test that was checking for this when using traffic routing

Signed-off-by: mitchell amihod <[email protected]>
    @meeech
    meeech committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    9ffec5e View commit details
    Browse the repository at this point in the history