Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retain TLS configuration for canary ingresses in the nginx inte… #2831

Closed
wants to merge 1 commit into from
Closed

feat: retain TLS configuration for canary ingresses in the nginx inte… #2831

wants to merge 1 commit into from

Conversation

andyliuliming
Copy link
Contributor

@andyliuliming andyliuliming commented Jun 11, 2023 •
edited
Loading

…gration. Fixes #1134 (#2679)

  • Retain TLS configuration for canary ingresses in the nginx integration

  • Retain TLS configuration for canary ingresses in the nginx integration

  • fixed tests after multiple nginx ingress merge

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andyliuliming
Copy link
Contributor Author

@zachaller is it possible to cherry-pick this to the 1.5 release? thanks.
this is blocking us onboarding to argo rollouts.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2023 •
edited
Loading

E2E Tests Published Test Results

    4 files      4 suites   3h 31m 4s ⏱️
  96 tests   84 ✔️   5 💤   7 ❌
398 runs  364 ✔️ 20 💤 14 ❌

For more details on these failures, see this check.

Results for commit 54a7c76.

♻️ This comment has been updated with latest results.

@pfyod @andyliuliming
feat: retain TLS configuration for canary ingresses in the nginx inte…
54a7c76 
…gration. Fixes argoproj#1134 (argoproj#2679)

* Retain TLS configuration for canary ingresses in the nginx integration

Signed-off-by: Pavels Fjodorovs <[email protected]>

* Retain TLS configuration for canary ingresses in the nginx integration

Signed-off-by: Pavels Fjodorovs <[email protected]>

* fixed tests after multiple nginx ingress merge

Signed-off-by: Pavels Fjodorovs <[email protected]>

---------

Signed-off-by: Pavels Fjodorovs <[email protected]>
Signed-off-by: Pavels Fjodorovs <[email protected]>
Signed-off-by: Liming Liu <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller
Copy link
Collaborator

This is released in 1.6

@zachaller zachaller closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyliuliming @zachaller @pfyod