Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve args to metric in garbage collection function #2843

Merged
merged 7 commits into from
Jun 15, 2023
Merged

fix: resolve args to metric in garbage collection function #2843

merged 7 commits into from
Jun 15, 2023

Commits on Jun 14, 2023

  1. resolve args to metric in garbage collection function 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    1aca530 View commit details
    Browse the repository at this point in the history

  2. remove incorrectly added test, this moved to a function 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6620c1b View commit details
    Browse the repository at this point in the history

  3. re-trigger 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    879462a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:argoproj/argo-rollouts into fix-r… 

    …esolveargs-for-gc
    @zachaller
    zachaller committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9366a8e View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. add context to errors 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    50b8156 View commit details
    Browse the repository at this point in the history

  2. better error message 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8f7ef96 View commit details
    Browse the repository at this point in the history

  3. better error message 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c9dd7ea View commit details
    Browse the repository at this point in the history