Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable self service notification support #2869

Closed
wants to merge 13 commits into from

Conversation

zachaller
Copy link
Collaborator

Allow rollouts to define configuration for notification engine in the namespace of the rollout resource.

Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Go Published Test Results

2 030 tests   2 030 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 444b80a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 44m 54s ⏱️
102 tests   82 ✔️   6 💤 14
432 runs  385 ✔️ 24 💤 23

For more details on these failures, see this check.

Results for commit 444b80a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 90.19% and project coverage change: -0.01 ⚠️

Comparison is base (20e00e4) 81.68% compared to head (444b80a) 81.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
- Coverage   81.68%   81.67%   -0.01%     
==========================================
  Files         133      133              
  Lines       20309    20310       +1     
==========================================
  Hits        16589    16589              
- Misses       2862     2863       +1     
  Partials      858      858              
Impacted Files Coverage Δ
utils/record/record.go 79.75% <61.53%> (-0.34%) ⬇️
controller/controller.go 89.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
@zachaller zachaller changed the title feat: enable self service rollouts feat: enable self service notification support Jul 13, 2023
@zachaller zachaller marked this pull request as ready for review July 14, 2023 14:53
@zachaller zachaller added this to the v1.6 milestone Jul 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
18.0% 18.0% Duplication

@zachaller zachaller closed this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant