Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump gotestsum and fix flakey test causing nil channel send #2934

Merged
merged 5 commits into from
Aug 9, 2023
Merged

chore: bump gotestsum and fix flakey test causing nil channel send #2934

merged 5 commits into from
Aug 9, 2023

Commits on Aug 8, 2023

  1. chore: bump gotestsum 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c0e041e View commit details
    Browse the repository at this point in the history

  2. Change order of defer prevent using closed channel 

    So deferes are called in a last-in-first-out order this means,
that we would close the channel before canceling the context which could
lead to a nil pointer usage. Let's just manually control order.

Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    e7563e7 View commit details
    Browse the repository at this point in the history

  3. cleanup 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    70a74dc View commit details
    Browse the repository at this point in the history

  4. change order to always be able to cleanup 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    73de7a6 View commit details
    Browse the repository at this point in the history

  5. deregister callback to avoid sending on closed channel 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d770d5b View commit details
    Browse the repository at this point in the history