Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update all ingress objects to networking.k8s.io/v1 #3005

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

therealdwright
Copy link
Contributor

@therealdwright therealdwright commented Sep 1, 2023

This commit updates all Kubernetes ingress rules in Argo Rollouts
to use the stable networking.k8s.io/v1 API, ensuring compatibility
with Kubernetes v1.19+ and leveraging new features available in the
stable version.

Closes #3004

Signed-off-by: Daniel Wright [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

This commit updates all Kubernetes ingress rules in Argo Rollouts
to use the stable `networking.k8s.io/v1` API, ensuring compatibility
with Kubernetes v1.19+ and leveraging new features available in the
stable version.

Signed-off-by: Daniel Wright <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (9906c37) 81.76% compared to head (a41ebcb) 81.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
- Coverage   81.76%   81.74%   -0.02%     
==========================================
  Files         134      134              
  Lines       20386    20386              
==========================================
- Hits        16668    16665       -3     
- Misses       2861     2865       +4     
+ Partials      857      856       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Go Published Test Results

2 044 tests   2 044 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit a41ebcb.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 36m 24s ⏱️
102 tests   87 ✔️   6 💤   9
426 runs  384 ✔️ 24 💤 18

For more details on these failures, see this check.

Results for commit a41ebcb.

@zachaller zachaller merged commit 607de81 into argoproj:master Sep 3, 2023
27 checks passed
@zachaller
Copy link
Collaborator

Thank you for the contributions, I am also tracking code changes on this that will we have to remove support for v1beta one once we upgrade client libs to 1.26

@therealdwright therealdwright deleted the update-ingress-versions branch September 3, 2023 22:47
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
This commit updates all Kubernetes ingress rules in Argo Rollouts
to use the stable `networking.k8s.io/v1` API, ensuring compatibility
with Kubernetes v1.19+ and leveraging new features available in the
stable version.

Signed-off-by: Daniel Wright <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all Kubernetes ingress rules to networking.k8s.io/v1
2 participants