chore: updating getCanaryConfigId to be more efficient with better error handling #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dling Signed-off-by: zhaque44 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3070 +/- ##
==========================================
- Coverage 81.74% 81.73% -0.01%
==========================================
Files 134 134
Lines 20398 20394 -4
==========================================
- Hits 16674 16670 -4
Misses 2866 2866
Partials 858 858
☔ View full report in Codecov by Sentry. |
|
@zachaller can you take a look at this PR, I think its only failing b/c it wants a test for this |
zachaller
approved these changes
Oct 2, 2023
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 13, 2023
…ror handling (argoproj#3070) updating getCanaryConfigId to be more efficient with better error handling Signed-off-by: zhaque44 <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…ror handling (argoproj#3070) updating getCanaryConfigId to be more efficient with better error handling Signed-off-by: zhaque44 <[email protected]> Signed-off-by: Philip Clark <[email protected]>
phclark
pushed a commit
to phclark/argo-rollouts
that referenced
this pull request
Oct 15, 2023
…ror handling (argoproj#3070) updating getCanaryConfigId to be more efficient with better error handling Signed-off-by: zhaque44 <[email protected]> Signed-off-by: Philip Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
getCanaryConfigIdfunc:Error Handling:It now handles errors more cleanly.Resource Management:It closes the HTTP response body to prevent resource leaks.Last but not least it simplifies things by reducing nesting and using the defer statement for cleanup.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".