Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for reconcileEphemeralMetadata() #3163

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

zhaque44
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@zhaque44 zhaque44 changed the title add test for reconcileEphemeralMetadata() chore: add test for reconcileEphemeralMetadata() Nov 10, 2023
Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8f0aa4) 81.83% compared to head (227cd31) 81.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
+ Coverage   81.83%   81.85%   +0.01%     
==========================================
  Files         134      134              
  Lines       20556    20556              
==========================================
+ Hits        16823    16826       +3     
+ Misses       2869     2866       -3     
  Partials      864      864              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Go Published Test Results

2 084 tests   2 084 ✔️  2m 48s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 227cd31.

Copy link
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 29m 5s ⏱️
103 tests   90 ✔️   6 💤   7
432 runs  389 ✔️ 24 💤 19

For more details on these failures, see this check.

Results for commit 227cd31.

@zachaller zachaller enabled auto-merge (squash) November 11, 2023 01:42
@zachaller zachaller merged commit 39d21ae into argoproj:master Nov 11, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants