docs(deps): Specify minimum kustomize version #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3199 +/- ##
==========================================
+ Coverage 81.84% 81.85% +0.01%
==========================================
Files 134 134
Lines 20558 20558
==========================================
+ Hits 16825 16828 +3
+ Misses 2869 2866 -3
Partials 864 864 ☔ View full report in Codecov by Sentry. |
kzap
force-pushed
the
amt-kustomize-test-version
branch
from
0672f56
to
3499dfe
Compare
kzap
changed the title
kzap
changed the title
…g a different version of kustomize Signed-off-by: Andre Marcelo-Tanner <[email protected]>
Signed-off-by: Andre Marcelo-Tanner <[email protected]>
kzap
force-pushed
the
amt-kustomize-test-version
branch
from
aaaf5bd
to
460cedf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
Dec 3, 2023
ashutosh16
pushed a commit
to ashutosh16/argo-rollouts
that referenced
this pull request
Dec 8, 2023
* Tests require atleast kustomize v4.5.5, install v5.2.1 if we are using a different version of kustomize Signed-off-by: Andre Marcelo-Tanner <[email protected]> * revert version upgrade and just rely on docs Signed-off-by: Andre Marcelo-Tanner <[email protected]> --------- Signed-off-by: Andre Marcelo-Tanner <[email protected]> Signed-off-by: ashutosh16 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quality of life improvement. The use of openapi in kustomize requires we use atleast v4.5.5
argo-rollouts/test/kustomize/rollout/kustomization.yaml
Lines 45 to 46 in 33e0612
Adding a line to the contributor docs to indicate what version of kustomize we need.
I was considering scripting to download a known version of kustomize but that felt too complicated vs some documentation for the developer.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".