Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove year from codegen license #3282

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jan 2, 2024

Match ArgoCD codegen license: https://github.com/argoproj/argo-cd/blob/master/hack/boilerplate.go.txt

This prevents the year from being put into the auto generated code which needs a PR every new year.

@zachaller zachaller changed the title chore: run codegen in 2024 chore: remove year from codegen license Jan 2, 2024
@zachaller zachaller marked this pull request as ready for review January 2, 2024 17:34
Copy link

sonarcloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (192009a) 81.83% compared to head (6cd5c8b) 81.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   81.83%   81.82%   -0.02%     
==========================================
  Files         135      135              
  Lines       20633    20633              
==========================================
- Hits        16885    16882       -3     
- Misses       2877     2880       +3     
  Partials      871      871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 6cd5c8b.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller enabled auto-merge (squash) January 2, 2024 18:04
@zachaller zachaller merged commit 0fab0f2 into argoproj:master Jan 2, 2024
23 checks passed
zachaller added a commit that referenced this pull request Jan 24, 2024
* chore: run codegen in 2024

Signed-off-by: Zach Aller <[email protected]>

* chore: remove year from codegen

Signed-off-by: Zach Aller <[email protected]>

* chore: remove year from codegen

Signed-off-by: Zach Aller <[email protected]>

---------

Signed-off-by: Zach Aller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants