Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add exception to requireCanaryStableServices to disable validation when using the hashicorp/consul plugin #3339

Merged
merged 5 commits into from
Feb 12, 2024
Merged

chore: Add exception to requireCanaryStableServices to disable validation when using the hashicorp/consul plugin #3339

merged 5 commits into from
Feb 12, 2024

Commits on Feb 12, 2024

  1. add exception to requireCanaryStableServices to disable validation … 

    …when using the `hashicorp/consul` plugin

Co-authored-by: Ashwin Venkatesh <[email protected]>
Signed-off-by: Michael Wilkerson <[email protected]>
    @wilkermichael @thisisnotashwin
    wilkermichael and thisisnotashwin committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    7836d38 View commit details
    Browse the repository at this point in the history

  2. added HashiCorp to USERS.md 

    Co-authored-by: Ashwin Venkatesh <[email protected]>
Signed-off-by: Michael Wilkerson <[email protected]>
    @wilkermichael @thisisnotashwin
    wilkermichael and thisisnotashwin committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    bb6d86e View commit details
    Browse the repository at this point in the history

  3. modified requireCanaryStableServices to reverse logic 

    - added test cases for exceptions to requiring checks for Canary/Stable services
- added test cases for verifying errors when Canary/Stable services are missing

Co-authored-by: Ashwin Venkatesh <[email protected]>
Signed-off-by: Michael Wilkerson <[email protected]>
    @wilkermichael @thisisnotashwin
    wilkermichael and thisisnotashwin committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    06a85d1 View commit details
    Browse the repository at this point in the history

  4. addressed comments and added more test cases 

    Co-authored-by: Ashwin Venkatesh <[email protected]>
Signed-off-by: Michael Wilkerson <[email protected]>
    @wilkermichael @thisisnotashwin
    wilkermichael and thisisnotashwin committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    36c169b View commit details
    Browse the repository at this point in the history

  5. modified requireCanaryStableServices to reverse logic 

    - added test cases for exceptions to requiring checks for Canary/Stable services
- added test cases for verifying errors when Canary/Stable services are missing

Co-authored-by: Ashwin Venkatesh <[email protected]>
Signed-off-by: Michael Wilkerson <[email protected]>
    @wilkermichael @thisisnotashwin
    wilkermichael and thisisnotashwin committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    74cf023 View commit details
    Browse the repository at this point in the history