Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for maxSurge=0, replicas=1 #3375

Merged
merged 4 commits into from
Feb 15, 2024

Merge branch 'master' into add-test-no-surge-one-replica

3acd985
Select commit
Loading
Failed to load commit list.
Merged

test: add unit tests for maxSurge=0, replicas=1 #3375

Merge branch 'master' into add-test-no-surge-one-replica
3acd985
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 15, 2024 in 0s

82.98% (+1.14%) compared to 8405f2e

View this Pull Request on Codecov

82.98% (+1.14%) compared to 8405f2e

Details

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (8405f2e) 81.83% compared to head (3acd985) 82.98%.
Report is 15 commits behind head on master.

Files Patch % Lines
controller/controller.go 21.68% 61 Missing and 4 partials ⚠️
utils/record/record.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
+ Coverage   81.83%   82.98%   +1.14%     
==========================================
  Files         135      135              
  Lines       20688    16854    -3834     
==========================================
- Hits        16931    13986    -2945     
+ Misses       2883     1996     -887     
+ Partials      874      872       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.