Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor readability on migration #3427

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Mar 6, 2024

the ordered list was 1-2-3-1
fixed the indentation

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

the ordered list was 1-2-3-1
fixed the indentation

Signed-off-by: Carlos Sanchez <[email protected]>
@carlossg carlossg marked this pull request as ready for review March 6, 2024 18:52
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Go Published Test Results

2 137 tests   2 137 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit e86af42.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (8405f2e) to head (e86af42).
Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3427      +/-   ##
==========================================
+ Coverage   81.83%   82.90%   +1.06%     
==========================================
  Files         135      135              
  Lines       20688    16922    -3766     
==========================================
- Hits        16931    14029    -2902     
+ Misses       2883     2015     -868     
- Partials      874      878       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 41m 50s ⏱️
108 tests 100 ✅  6 💤 2 ❌
436 runs  408 ✅ 24 💤 4 ❌

For more details on these failures, see this check.

Results for commit e86af42.

@zachaller zachaller merged commit a9a5192 into argoproj:master Mar 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants