fix: protocol missing in ambassador canary mapping creation. Fixes #3593 #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go Published Test Results2 162 tests 2 162 ✅ 2m 54s ⏱️ Results for commit c065051. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3603 +/- ##
==========================================
+ Coverage 80.26% 80.28% +0.02%
==========================================
Files 156 156
Lines 17969 17964 -5
==========================================
Hits 14423 14423
+ Misses 2634 2630 -4
+ Partials 912 911 -1 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 26m 27s ⏱️ For more details on these failures, see this check. Results for commit c065051. ♻️ This comment has been updated with latest results. |
umjoshua
force-pushed
the
ambassador_mapping_fix
branch
2 times, most recently
from
bae86dd
to
b33f434
Compare
zachaller
changed the title
zachaller
changed the title
Signed-off-by: Joshua Mathew <[email protected]>
zachaller
force-pushed
the
ambassador_mapping_fix
branch
from
b33f434
to
c065051
Compare
|
zachaller
approved these changes
Jun 12, 2024
zachaller
pushed a commit
that referenced
this pull request
Jun 13, 2024
(#3603) fix protocol missing in ambassador canary mapping creation Signed-off-by: Joshua Mathew <[email protected]>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3593
Checklist:
"fix(controller): Updates such and such. Fixes #1234".