fix(metricprovider): reuse http.Transport for http.Client #3780
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code creates a new http.Transport for each http.Client that is created, which leads to a leak in TCP connections due to keep-alive.
Instead, reuse the same http.Transport between requests. According to the http.Transport docs, this is safe for concurrent use.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.