feat(metricprovider): credentials to download plugin #3905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Published E2E Test Results 4 files 4 suites 3h 15m 12s ⏱️ For more details on these failures, see this check. Results for commit cfa0cf8. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 283 tests 2 283 ✅ 2m 59s ⏱️ Results for commit cfa0cf8. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
==========================================
+ Coverage 82.69% 82.99% +0.30%
==========================================
Files 163 163
Lines 22886 22905 +19
==========================================
+ Hits 18925 19010 +85
+ Misses 3087 3024 -63
+ Partials 874 871 -3 ☔ View full report in Codecov by Sentry. |
ariadnarouco
changed the title
ariadnarouco
force-pushed
the
plugin
branch
3 times, most recently
from
955ac0a
to
cfa0cf8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our company, we have a use case where we need to create a new plugin as a metric provider. For security reasons the plugin needs to be private and cannot be uploaded to a public storage.
Therefore, we have the need to use credentials for downloading the plugin securely.
We have followed k8s secretRef pattern to specify how the credentials are passed.
Additionally, we had an issue with 404 status code. The downloader says that the plugin is downloaded correctly but it’s not true.
Fixes: #3708
Checklist:
"fix(controller): Updates such and such. Fixes #1234".