v3.4.8 not working with BASE_HREF

[gabrielfsousa]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

if i configure

         env:
          - name: BASE_HREF
            value: /argo/

i have a blank page

Version

v3.4.8

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

blank page

Logs from the workflow controller

theres are no error messages

Logs from in your workflow's wait container

theres are no error messages

[caelan-io]

@tico24 confirmed this is a bug on v3.4.8 - I don't believe any fixes pushed in v3.4.9 would fix this, but maybe someone else knows.

[JPZ13]

Given this is a regression, let's see if we can add a test on the PR that fixes it so that we don't run into it again on a go forward

[agilgur5]

This appears to actually duplicate an older issue with several comments: #10194

Not sure how long this has been broken for. Also not actually sure if this is an Argo bug per se or just a cluster misconfiguration, as #3080 has various configurations for all sorts of Ingresses to get it to work

[agilgur5]

Also not actually sure if this is an Argo bug per se or just a cluster misconfiguration, as #3080 has various configurations for all sorts of Ingresses to get it to work

Ok so I looked through the BASE_HREF history in the repo (search BASE_HREF and baseHref) and there have not been changes to those in 3-4+ years, so I believe this is indeed due to cluster misconfiguration and therefore working correctly.

BASE_HREF does not change where Argo serves from, it changes what Argo interprets as the base. Per the Base HREF docs, it is intended for proxying. As in, if your Ingress has the Argo Server at /argo/, you'll need to set BASE_HREF to /argo/. But if you have no proxy in front or are serving at / (i.e. not at a subpath), then you shouldn't set BASE_HREF.
See also MDN docs on the HTML base element.

[agilgur5]

From my most recent comment in #10194, looks like folks might be looking for rootpath support, i.e. #7767.

Both in #10194 and #11643, BASE_HREF is indeed being set correctly, per the Server logs and the HTML response. It seems like folks are just expecting it to act like rootpath, which is actually a separate feature that is not yet implemented.

Going to close this one out as such

[sonbui00]

@agilgur5 I found the issue on this. Please help me reopen