-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add GH Action for /retest
comments to re-run failed jobs
#12864
Labels
area/build
Build or GithubAction/CI issues
solution/suggested
A solution to the bug has been suggested. Someone needs to implement it.
type/feature
Feature request
Comments
agilgur5
added
type/feature
Feature request
area/build
Build or GithubAction/CI issues
solution/suggested
A solution to the bug has been suggested. Someone needs to implement it.
labels
Mar 30, 2024
This is fine. We use this for other projects as well |
@agilgur5 I could have a look into this if it is up for grabs |
Go for it |
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 1, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 1, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
5 tasks
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 1, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 1, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 2, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 2, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 2, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 2, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
agilgur5
added a commit
that referenced
this issue
May 2, 2024
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: Miltiadis Alexis <[email protected]>
miltalex
added a commit
to miltalex/argo-workflows
that referenced
this issue
May 4, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
agilgur5
pushed a commit
that referenced
this issue
May 4, 2024
Signed-off-by: Miltiadis Alexis <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/build
Build or GithubAction/CI issues
solution/suggested
A solution to the bug has been suggested. Someone needs to implement it.
type/feature
Feature request
Summary
Create a GH Action Workflow that reads comments by Members on PRs and detects
/retest
. If detected, it should use the GH API to "re-run failed jobs".Right now this permission is limited to Approver+ (those with "write" permissions), so the Action can perform this on behalf of Members and Reviewers. This will be particularly useful for test flakes.
This would be similar to upstream k8s's bot that reruns CI after detecting a
/retest
commentUse Cases
In particular, this is useful when the repo has a bout of flakey tests, such as:
TestStoppedWorkflow
fail sometimes (flakey test) #12836,TestTemplateExecutor
fails sometimes (flakey test) #12832, Flakey tests #10807, Flakey tests #7133, etc etcContributors, including me, have asked how to retry in those cases in the past:
Pushing an empty commit (or closing/re-opening the PR) works, but re-runs all GH jobs, not just the failed one(s).
/retest
to only re-run failed jobs would be faster and more efficient.While we should fix test flakes -- especially as they sometimes are due to unhandled race conditions in the source code (not just test races) -- in the interim, while they are being diagnosed, root caused, and fixed, such a
/retest
command is very useful.Implementation Details
Similar to #12592 (comment) for
/cherry-pick
, we can run an action when a comment is made on a PR:if: github.event.comment.author_association == 'MEMBER'
CommentAuthorAssociation
docs for more details. We could extend that to'CONTRIBUTOR'
if we wanted to as well.gh run rerun RUN_ID --failed
RUN_ID
from the PR number. I think there's several ways of doing that and seemingly no shortcut command?We could also extract 2 into its own separate OSS action for other repos to use. I couldn't find one from some searching so I don't think it exists already?
Message from the maintainers:
Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.
The text was updated successfully, but these errors were encountered: