#47: Moved the setter functions to ngOnChange #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we need this change? Does it fix any issue or is it refactoring ? |
|
Got it. I guess you mean issue #48 . Setter does not set any value, it is not angular bug. Thank you for fixing it ! |
alexmt
approved these changes
Aug 31, 2017
alexmt
pushed a commit
that referenced
this pull request
Aug 31, 2017
wokeGit
pushed a commit
to wokeGit/argo
that referenced
this pull request
Nov 20, 2017
wokeGit
pushed a commit
to wokeGit/argo
that referenced
this pull request
Nov 21, 2017
wokeGit
pushed a commit
to wokeGit/argo
that referenced
this pull request
Nov 22, 2017
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.