fix: upgrade argo-ui components to latest
#11585
Conversation
…oproj#11448 Signed-off-by: Yuan Tang <[email protected]>
- need to use `esModuleInterop` to [match Argo UI](https://github.com/argoproj/argo-ui/blob/87d27fb1cb4f6e3ac4a49f85747e471b2efa7512/tsconfig.json#L9) as we are currently importing source TS and not compiled JS - `classnames` and `moment` _then_ needed to use default imports instead of namespace imports Signed-off-by: Anton Gilgur <[email protected]>
- be specific with a SHA - `@types/uuid` is needed to fix lack of types - see also similar commit in Argo CD: argoproj/argo-cd@26d5ad6 - which is a follow-up to Argo UI: argoproj/argo-ui@06d0e88 Signed-off-by: Anton Gilgur <[email protected]>
- fixes `react-toastify` ESM import errors - this was pinned to 9.0.8 in argoproj/argo-ui@25663b0, but >9.0.4 seems to require Webpack v5 - see https://stackoverflow.com/a/72681750/3431180 and related links. these are about CRA, which we don't use, but it appears to affect upstream Webpack, which we do use - notably, Argo CD uses [Webpack v5](https://github.com/argoproj/argo-cd/blob/bfaac2b5ac4b96c8af8158902c1b086f7ced7389/ui/package.json#L119) and hence did not see this error Signed-off-by: Anton Gilgur <[email protected]>
- see https://github.com/foundation/foundation-sites/releases/tag/v6.7.0 which had various upgrades and compat fixes - no build errors anymore! Signed-off-by: Anton Gilgur <[email protected]>
Just noting here that I did not do a full test of rendering the UI, as this my first time touching the UI build process so I still need to figure all that out. From a spot test running There was one piece of the |
agilgur5
added
type/dependencies
|
|
|
@terrytangyuan @sarabala1979 - did this PR ever get merged in to a v3.4.x commit? I'm looking through v3.4.16 and don't see it |
|
It's not in the 3.4.x changelog and didn't make it into 3.4.11 which is the only release issue back linked above. I imagine this one might have had cherry-pick issues due to the |
|
If it's not in changelog then there must have been a conflict. See #11648 (comment) and the comment above and this commit is mentioned as not successfully cherry-picked. |
A cherry pick of argoproj#11585 to release/3.4 Changes from argoproj#11585: * `archived-workflow-details.tsx` changes to `className` * `yarn.lock` updated, `react-toastify` still pinned to 9.0.3 Co-authored-by: Anton Gilgur <[email protected]> Co-authored-by: Yuan Tang <[email protected]> Signed-off-by: Alan Clucas <[email protected]>
Replaces #11510, fixes all issues I commented about
Fixes #11448 by incorporating argoproj/argo-ui#418
Motivation
argo-uicomponentsModifications
Pin
argo-uito latest SHA: argoproj/argo-ui@87d27fb@types/uuidto fix lack of typing (see chore: upgrade uuid argo-ui#367 and chore: bump argo-ui version argo-cd#13836)react-toastifyto 9.0.3esModuleInteropas this was added in Argo UI, and since Argo UI is not compiled (we import source TS), we have to match itstsconfig.jsonto get the same resultsclassnamesandmomentinstead of namespace imports to fix the remaining import errors (as the errors suggest)Update
foundation-sitesto fix SCSS deprecation warningsVerification