fix: Replace antonmedv/expr with expr-lang/expr #11971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Tang <[email protected]>
rbreeze
approved these changes
Oct 9, 2023
agilgur5
reviewed
Oct 9, 2023
| @@ -279,4 +279,7 @@ require ( | |||
| sigs.k8s.io/structured-merge-diff/v4 v4.2.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/go-git/go-git/v5 => github.com/argoproj-labs/go-git/v5 v5.4.7 | |||
| replace ( | |||
| github.com/antonmedv/expr => github.com/expr-lang/expr v0.0.0-20230912141041-709c5dd55aa7 | |||
There was a problem hiding this comment.
Confirmed that this commit SHA matches the one I confirmed to be from the original repo in #11964 (reply in thread).
Per my comment there though, we do not yet have confirmation from the author that expr-lang/expr is an "official" fork. I think we should wait for confirmation from the author or use a known, trusted fork in the interim (such as my fork)
agilgur5
added
type/dependencies
|
Let's hold off on merging until the original author confirms. |
|
The author confirmed so we should be good to proceed |
agilgur5
approved these changes
Oct 9, 2023
|
Reverted this in #12033 since the original/root fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link is down and the author has created a fork in expr-lang. We use a
replacehere since the original repo would likely recover once GitHub handles the issue.