Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows): prevent infinite run. Fixes #11810 #11993

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix(windows): prevent infinite run. Fixes #11810 #11993

merged 1 commit into from
Oct 13, 2023

Commits on Oct 13, 2023

  1. fix(windows): prevent infinite run. Fixes argoproj#11810 

    windows based workflows already call .Wait() in signal_windows.go,
calling it twice will result in not exiting at all.

Unix based workflows prevent that by releasing the process early on
and checking exit code of all running processes.

Windows workflows don't do this and without knowing in-depth how windows
processes work, I didn't find a way to achieve a similar "wait for all
processes" syscall.

Signed-off-by: Michael Weibel <[email protected]>
    @mweibel
    mweibel committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    21f3250 View commit details
    Browse the repository at this point in the history