fix(ui): missing uiUrl in ArchivedWorkflowsList
#12172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `BASE_HREF` was not handled in a few places and Archived Workflows specifically was missed as it was removed in the 3.5 release - this PR is to the 3.4.x branch Signed-off-by: Anton Gilgur <[email protected]>
This was referenced Nov 9, 2023
terrytangyuan
approved these changes
Nov 16, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Dillen Padhiar <[email protected]>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9764 (comment)
Motivation
BASE_HREFwas not handled in a few places and Archived Workflows specifically was missed as it was removed in the 3.5 releaseModifications
uiUrlto the one missing place in an Archived Workflows component/archived-workflows/)Verification
Notes for Reviewers
I added this to theEDIT: updated to 3.4.14 release branchrelease-3.4.13branch as there is no 3.4.14 branch yet. We'll want to modify the branch base once that exists.I might suggest having a running
3.4.x(etc) branch in order to have an ongoing branch, and then just tag patches off of that