fix: improve resource duration accuracy. Fixes #12468 #12492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AloysAqemia
force-pushed
the
fix/resources-duration
branch
from
7c0adc1
to
6fc9d76
Compare
|
Thanks for taking a look @agilgur5 ! |
The `.Values()` function rounds cpu ressources up to an integer. As a result, containers with small cpu requests (like the sidecar that requests 10m cores) are counted as requiring one full core, making the resources duration computation quite inaccurate. This changes uses `.MilliValues()` instead. The `MilliValues()` documentation mentions that this function may overflow, but the return value is stored in an int64, so the overflow will happen if a container requests more than 9*10^(15) of a ressource. I assume this should be fine for a while. Signed-off-by: Aloÿs Augustin <[email protected]>
AloysAqemia
force-pushed
the
fix/resources-duration
branch
from
6fc9d76
to
9d3bb42
Compare
|
It turns out removing the conversion of age into seconds caused an overflow as |
|
Oh, good find! I would not have expected an overflow and did not know that |
agilgur5
reviewed
Jan 9, 2024
agilgur5
approved these changes
Jan 12, 2024
terrytangyuan
approved these changes
Feb 5, 2024
This was referenced Feb 5, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 20, 2024
…rgoproj#12492) Signed-off-by: Aloÿs Augustin <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…rgoproj#12492) Signed-off-by: Aloÿs Augustin <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
…rgoproj#12492) Signed-off-by: Aloÿs Augustin <[email protected]> Signed-off-by: Isitha Subasinghe <[email protected]>
agilgur5
changed the title
agilgur5
changed the title
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
…rgoproj#12492) Signed-off-by: Aloÿs Augustin <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
…rgoproj#12492) Signed-off-by: Aloÿs Augustin <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
…rgoproj#12492) Signed-off-by: Aloÿs Augustin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12468
Motivation
Fix cpu ressources consumption estimation.
Modifications
Change the use of the
.Values()function (which rounds ressources up to an integer) to.MilliValues()which is more accurate for CPU resources, which can be fractional.The
MilliValues()documentation mentions that this function may overflow, but the return value is stored in an int64, so the overflow will happen if a container requests more than 9*10^(15) of a ressource. I assume this should be fine for a while.Verification
Tested by submitting the workflow attached to the issue this PR fixes. The result is now what is expected: