fix: artifact subdir error when using volumeMount #12638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <[email protected]>
Signed-off-by: Tianchu Zhao <[email protected]>
Signed-off-by: Tianchu Zhao <[email protected]>
Signed-off-by: Tianchu Zhao <[email protected]>
tczhao
changed the title
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 20, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Isitha Subasinghe <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
bishengliu7
reviewed
Mar 28, 2024
| @@ -204,6 +204,11 @@ func (we *WorkflowExecutor) LoadArtifacts(ctx context.Context) error { | |||
| // the file is a tarball or not. If it is, it is first extracted then renamed to | |||
| // the desired location. If not, it is simply renamed to the location. | |||
| tempArtPath := artPath + ".tmp" | |||
| // Ensure parent directory exist, create if missing | |||
| tempArtDir := filepath.Dir(tempArtPath) | |||
| if err := os.MkdirAll(tempArtDir, 0o700); err != nil { | |||
There was a problem hiding this comment.
The code here creates a temporary path, then artifact driver will load(download) the object to this path.
The minimum dir permission across the artifact drivers is 700.
Are you experiencing an issue with this?
tczhao
added a commit
to tczhao/argo
that referenced
this pull request
Apr 19, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12174
I tried contacting original author from #12200 but met no success
We want to expedite this fix and have this ready for the next patch release
Motivation
To make sure if an artifact contains a subdir and is mounted using volume claim, the workflow runs without failing.
VolumeMount is necessary if the user wants to use ephemeral storage.
Modifications
Make sure the executor creates a subdirectory before downloading files
Verification
Added new e2e test -> e2e failed (verified original issue)
Added code change -> e2e succeed (verified fixed the issue)