fix: find correct retry node when using templateRef. Fixes: #12633
#12683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuangkun <[email protected]>
agilgur5
added
the
area/retry-manual
Joibel
reviewed
Feb 21, 2024
Joibel
approved these changes
Feb 21, 2024
|
Thanks! |
agilgur5
changed the title
templateRef. Fixes: #12633
agilgur5
reviewed
Feb 21, 2024
| BoundaryID: "A1", | ||
| Children: []string{}, | ||
| TemplateRef: &wfv1.TemplateRef{ | ||
| Name: "tmpl1", |
There was a problem hiding this comment.
shouldn't this have a template field as well? the test is passing with only name?
There was a problem hiding this comment.
the test is passing with only
name?
Oh I guess the test passed bc nil == nil. The code checks whether the templateRef struct isn't nil, but not the individual fields.
They should never be nil in a real use-case, so I suppose that is a test edge-case
Signed-off-by: shuangkun <[email protected]>
agilgur5
approved these changes
Feb 22, 2024
This was referenced Feb 22, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…j#12633 (argoproj#12683) Signed-off-by: shuangkun <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
…j#12633 (argoproj#12683) Signed-off-by: shuangkun <[email protected]> Signed-off-by: Isitha Subasinghe <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
…j#12633 (argoproj#12683) Signed-off-by: shuangkun <[email protected]>
6 tasks
agilgur5
added
area/retryStrategy
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
…j#12633 (argoproj#12683) Signed-off-by: shuangkun <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
…j#12633 (argoproj#12683) Signed-off-by: shuangkun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause is pod have
retryStrategy, the boundaryNode didn't have template (usetemplateRef), so when find retryNode, probabilistically found others and cause"failed to get a template".Some info help review:
Failed workflow(find the wrong retry node):
Succeed worklfow:
Fixes: #12633
Motivation
Modifications
Verification