Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: bump k8s dependencies to 1.27 #12865

Closed
wants to merge 4 commits into from
Closed

chore(deps)!: bump k8s dependencies to 1.27 #12865

wants to merge 4 commits into from

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Mar 30, 2024 •
edited
Loading

Motivation

  • Breaking change: Drops support for Kubernetes 1.23 clients
  • K8s 1.26 EOL was 2024-02-28

Modifications

  • updated go.mod to K8s 1.27
  • updated dist/kubernetes.swagger.json version to 1.27
  • updated workflow/executor/resource.go to non deprecated functions to appease the linter
  • changed getEvents test helper to truncate annotations from events so that TestEventNodeEvents passes

Verification

Existing test coverage is sufficient

@blkperl
chore(deps): bump k8s dependencies to 1.27
82a9426 
Signed-off-by: william.vanhevelingen <[email protected]>
@blkperl blkperl marked this pull request as draft March 30, 2024 19:17
@blkperl
test: fix TestEventNodeEvents
6cc5ac5 
Signed-off-by: william.vanhevelingen <[email protected]>
@blkperl blkperl marked this pull request as ready for review March 31, 2024 17:57
@blkperl
Copy link
Contributor Author

blkperl commented Mar 31, 2024

E2E failed due to #12836

@shuangkun shuangkun added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Apr 2, 2024
@blkperl blkperl changed the title chore(deps): bump k8s dependencies to 1.27 chore!(deps): bump k8s dependencies to 1.27 Apr 2, 2024
@blkperl blkperl changed the title chore!(deps): bump k8s dependencies to 1.27 chore(deps)!: bump k8s dependencies to 1.27 Apr 2, 2024
@blkperl blkperl requested a review from agilgur5 April 2, 2024 20:08
@blkperl
Copy link
Contributor Author

blkperl commented Apr 12, 2024

@terrytangyuan can you review please?

terrytangyuan
terrytangyuan reviewed Apr 12, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These separate PRs for each version bump did not help review at all (for me at least).

@agilgur5 agilgur5 added this to the v3.6.0 milestone Apr 17, 2024
@blkperl
Copy link
Contributor Author

blkperl commented Jul 30, 2024

closing in favor of #13413

@blkperl blkperl closed this Jul 30, 2024
@blkperl blkperl deleted the k8s_1.27 branch July 30, 2024 16:04
@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Jul 30, 2024
@blkperl blkperl mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@agilgur5 agilgur5 Awaiting requested review from agilgur5

Assignees
No one assigned
Labels
go Pull requests that update Go dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@blkperl @terrytangyuan @agilgur5 @shuangkun