ci(retest): filter more comments to use GHA less #13208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- they get triggerred [quite often](https://github.com/argoproj/argo-workflows/actions/workflows/retest.yaml) (for every comment), and though they only run for 2s, it would be good to filter out more of them and use less CI time - only run on `created` events, skip all `edited` events - the vast majority of `edited` events will be for unrelated comments - you can delete and comment again to trigger a retest instead if you had a typo - only run on PR comments - it would fail otherwise, but this prevents that scenario entirely Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
added
area/build
juliev0
approved these changes
Jul 6, 2024
juliev0
reviewed
Jul 6, 2024
Can confirm this worked in #13317 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #13000
Motivation
Modifications
only run on
createdevents, skip alleditedeventseditedevents will be for unrelated commentsonly run on PR comments, following GH docs
Verification