fix(cron): various follow-ups for multiple schedules

[eduardodbr]

Motivation

Currently argo cron list and argo cron get are showing the schedules with timezone, when available. This PR removes it as it doesn't bring any value because it can be seen in the timezone field.

Modifications

The schedule string can now be requested with and without the timezone.
With timezone, it is used for the annotation last-used-schedule, so changing the timezone while keeping the schedule will be seen as a new schedule.
Without timezone, it is used in argo cron CLI.

Also:

• update every instance of schedule to be schedules as suggested by @agilgur5 feat(cron): allow multiple schedules #12616 (comment)
• update fields in CronWorkflows table for multiple schedules per feat(cron): allow multiple schedules #12616 (review)
• add in-line version references and deprecation per feat(cron): allow multiple schedules #12616 (comment)
• add example

Verification

Current:

argo cron list

argo cron get

With this PR changes:

argo cron list

argo cron get

The CronWorkflow label last-used-schedule still uses the schedule with timezone

[agilgur5]

It might make sense to split out the schedule -> schedules change #12616 (comment) into its own PR. That and the v3.6 and after: and other #12616 review follow-ups can be merged pretty much immediately while you're still working out the test failures etc here. And the v3.6 and after: portion is particularly useful for people who are looking at the latest docs.

Also there was one miss from my previous review #12616 (review), the CronWorkflow docs page's fields table

[eduardodbr]

whille implementing this, I also found that schedule was still marked as required in the open api spec/json schema/CRD spec so I removed it. Do you think it should have a dedicated PR or is it ok to have it here? @agilgur5

[agilgur5]

Is the CLI fix only relevant to 3.6? Or does it also impact 3.5/3.4?

If these are all just follow-up fixes to the multiple schedules PR, we can leave it all as one I suppose -- just would rename the PR.

If the CLI fix is relevant to 3.5/3.4, then I think we should split the rest out, so that it can be backported

[eduardodbr]

this only applies to 3.6 as it was introduced in #12616

[agilgur5]

I know schedules was, but I wasn't sure if this TZ duplication happened in earlier versions with single schedule as well

[eduardodbr]

the timezone in argo cron list and argo cron get was also introduced in that PR

[agilgur5]

Ok gotcha, wanted to make sure since I hadn't reviewed that whole PR. Then let's just fix-up the title and description to include all follow-ups as one

Also btw, no need to quote reply if you're replying to the whole thing in order. Quoting is useful for replying to parts at a time or out of order comments. In this case they read fluidly down and so quoting actually reads duplicatively (and if everyone does it, causes those massive quote of quote of quote of quotes). Forum kiddie me of the past is happy to have learned that lol

[agilgur5]

Suggested change

	{(w.spec.schedule ?? '') != ''
	? w.spec.schedule
	: w.spec.schedules.map(schedule => (
	{w.spec.schedule || w.spec.schedules.map(schedule => (

this specific one can be further simplified

[agilgur5]

although tbh normalizing schedule to a single element array of schedules would be simpler to do everywhere

[Joibel]

@eduardodbr, any chance that you'd have a chance to fix/update this so it can go into 3.6?

We're currently missing the documentation on multiple schedules, which is in this PR.

[eduardodbr]

Hi @Joibel will try to finish this ASAP, sorry for the delay

[agilgur5]

some notes on in-line deprecation and versions

I also updated the PR title and description per my previous comment

[agilgur5]

Thanks for updating this! Just a small comment below

[agilgur5]

LGTM, thanks for iterating on this!

[agilgur5]

Looks like there's some test failures in CI