feat: Set steps.*.ip to a json list if the node is an aggregate
#13615
+197
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Melnick <[email protected]>
meln5674
force-pushed
the
feature/aggregate-daemon-ip
branch
from
c3baa65
to
8ed1252
Compare
4 tasks
agilgur5
changed the title
steps.*.ip to a json list if the node is an aggregate
agilgur5
added
area/templating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13614
Motivation
See #13614
Modifications
Aggregate nodes of demonized steps/tasks now have the
ipfield set to a JSON list of the pod IPs.Docs have been updated to note this fact.
Verification
An e2e test has been added in which a set of nginx damon pods are created and then curl'ed, one each for withSequence/Items/Param. I noticed there was no test for the original single pod ip functionality, so I added a test for it as well to confirm this did not break it.