Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix HttpHandler test #13624

Merged
merged 2 commits into from
Sep 19, 2024
Merged

test: fix HttpHandler test #13624

merged 2 commits into from
Sep 19, 2024

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Sep 19, 2024

http://dummy.restapiexample.com/api/v1/employees is called as a test endpoint in this test and must respond 2xx for this test to pass. It is offline, so switch to https://github.com.

If github is offline we're probably not running CI anyway.
Changed to the running httpbin Pod

Signed-off-by: Alan Clucas [email protected]

@Joibel Joibel self-assigned this Sep 19, 2024
@Joibel Joibel changed the title tests: fix HttpHandler test test: fix HttpHandler test Sep 19, 2024
Signed-off-by: Alan Clucas <[email protected]>
@Joibel Joibel added the area/build Build or GithubAction/CI issues label Sep 19, 2024
@Joibel Joibel enabled auto-merge (squash) September 19, 2024 12:07
Signed-off-by: Alan Clucas <[email protected]>
@Joibel Joibel enabled auto-merge (squash) September 19, 2024 12:27
@Joibel Joibel merged commit 9af4554 into main Sep 19, 2024
27 checks passed
@Joibel Joibel deleted the fix-http-test branch September 19, 2024 12:45
Joibel added a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Joibel added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants