-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Python SDK publish #7363
Merged
terrytangyuan
merged 21 commits into
argoproj:master
from
flaviuvadan:fv/py-sdk-publish
Dec 15, 2021
Merged
feat: Python SDK publish #7363
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
67f343a
feat: adjust name of generated Python SDK
flaviuvadan 377f5f4
feat: add back generate block to publish, remove `rm` commands since …
flaviuvadan 28ad57f
chore: Run make pre-commit -B
flaviuvadan 77e60ee
chore: merge master
flaviuvadan 31bb37b
feat: add PyPi publish token
flaviuvadan a77bfcc
feat: implement publish step of Python SDK
flaviuvadan a9aebc4
fix: adjust the way we perform substitution of the from the git tag …
flaviuvadan dec93d7
chore: generate Python SDK 6.0.0
flaviuvadan dd0f385
chore: make pre-commit -B
flaviuvadan 3aeee59
chore: regen SDK, fix examples
flaviuvadan c9fcf75
chore: make pre-commit -B
flaviuvadan e3bbbe9
chore: make pre-commit -B again
flaviuvadan c8cc33a
chore: merge upstream
flaviuvadan 04e7a86
feat: fix SDK
flaviuvadan 52520a6
feat: add SDK fix
flaviuvadan f1df1d3
chore: merge master
flaviuvadan 2dd7f5a
fix: move to testpypi for SDK publication test
flaviuvadan ba5ff4f
fix: Python SDK Makefile dist path and secret reference
flaviuvadan 6743861
fix: downgrade OpenAPI generator to 4.3.1
flaviuvadan 06bcdc0
-s
flaviuvadan 4e689ad
fix: go back to OpenAPI5, adjust examples, pre-commit
flaviuvadan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
Pipfile | ||
.vscode/ | ||
.idea/ | ||
.node-version | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have this yet but I can add before next release. Could you use your fork and https://test.pypi.org/ to test that the entire release process works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terrytangyuan I tested the release process and discovered two bugs:
${}
dist
path was missingI fixed those. During testing I had to name the package
argo-workflows-test
because I do not have permission toargo-workflows
. Here are the results: