fix: sort endpoint IP addresses before diffing #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cal before diffing.
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
- Coverage 48.21% 48.14% -0.08%
==========================================
Files 36 36
Lines 2833 2858 +25
==========================================
+ Hits 1366 1376 +10
- Misses 1330 1339 +9
- Partials 137 143 +6
Continue to review full report at Codecov.
|
alexmt
reviewed
Oct 13, 2020
| @@ -19,10 +19,17 @@ import ( | |||
| "k8s.io/apimachinery/pkg/util/strategicpatch" | |||
| "k8s.io/client-go/kubernetes/scheme" | |||
|
|
|||
| "k8s.io/kubernetes/pkg/api/endpoints" | |||
There was a problem hiding this comment.
nitpick: can you please group third party dependencies together?
|
@wtam2018 resolve merge conflicts please |
|
It's unfortunate that we're adding more dependencies on the k/k repo. #56 |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes argoproj/argo-cd#1816. For an Endpoint, unsorted/out of lexicographical order IP addresses in the desired state won't match the actual live state and the application won't able to move to "Synced" state. This PR adds normalize function to sort IP addresses before performing diff so that diff is successful and the application can go to "Synced" state.