Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce usage of k8s.io/kubernetes packages take 2 #258

Merged
merged 1 commit into from
Apr 20, 2021
Merged

refactor: reduce usage of k8s.io/kubernetes packages take 2 #258

merged 1 commit into from
Apr 20, 2021

Conversation

ash2k
Copy link
Member

@ash2k ash2k commented Apr 20, 2021 •
edited
Loading

Updates #56.

This is a reduced version of #205 that does not remove conversion.

@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.4% 10.4% Duplication

@ash2k ash2k mentioned this pull request Apr 20, 2021
Closed
alexmt
alexmt approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexmt alexmt merged commit 11e3221 into argoproj:master Apr 20, 2021
@ash2k ash2k deleted the ash2k/reduce-k8s.io-k-usage2 branch April 21, 2021 02:35
@alexmt alexmt mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ash2k @alexmt