Enable consumers of gitops-engine API to specify an alternative temp directory for generated manifests, as an alternative '/dev/shm' #613
+47
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See parent issue for details: #614
This PR:
tmpManifestPath
to public APIs:NewEngine
inpkg/engine/engine.go
NewClusterCache
in `pkg/cache/cluster.goio.TempPathUseDevShmIfAvailable()
(see examples in this PR)/dev/shm
will continue to do sopkg/utils/io/io.go
API to make it more explicit about behaviour