Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Engine should support a list of triggers from a single annotation #64

Closed
RaviHari opened this issue Jan 18, 2022 · 2 comments · Fixed by #65
Closed

Notification Engine should support a list of triggers from a single annotation #64

RaviHari opened this issue Jan 18, 2022 · 2 comments · Fixed by #65

Comments

@RaviHari
Copy link
Contributor

ref: argoproj/argo-rollouts#1783

Notification engine should handle multiple triggers in a given annotation:

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  annotations:
    notifications.argoproj.io/subscribe.on-rollout-completed,on-rollout-updated,on-rollout-pausedon-rollout-aborted,on-rollout-step-completed,on-scaling-replica-set.slack: ar-notifications-test
@jessesuen
Copy link
Member

@alexmt can you make these equivalent?

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  annotations:
    notifications.argoproj.io/subscribe.on-XXXXX.slack: ar-notifications-test
    notifications.argoproj.io/trigger-group.XXXXX: on-rollout-completed,on-rollout-updated,on-rollout-pausedon-rollout-aborted,on-rollout-step-completed,on-scaling-replica-set
  notifications.argoproj.io/subscribe_yaml: |
    - trigger: my-trigger1, my-trigger2, my-trigger3
      destinations:
        - service: my-service1
          recipients:
            - recipient-1
            - recipient-2

@alexmt
Copy link
Contributor

alexmt commented Feb 10, 2022

Here it is:

 notifications.argoproj.io/subscribe_yaml: |
    - trigger: [on-rollout-completed,on-rollout-updated,on-rollout-pausedon-rollout-aborted,on-rollout-step-completed,on-scaling-replica-set]
      destinations:
        - service: slack
          recipients: [ar-notifications-test]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants