Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update notifications engine to latest #2029

Closed

Conversation

todaywasawesome
Copy link
Contributor

Signed-off-by: todaywasawesome [email protected]

Notification Engine is several months behind and includes several bug fixes and two additional features.

argoproj/notifications-engine#90
argoproj/notifications-engine#78 and argoproj/notifications-engine#64
argoproj/notifications-engine#85 similar to #1958

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #2029 (f1c3827) into master (59f949c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2029   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         120      120           
  Lines       17054    17054           
=======================================
  Hits        14070    14070           
  Misses       2283     2283           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f949c...f1c3827. Read the comment docs.

Signed-off-by: todaywasawesome <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants