Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack param to disable link unfurling #242

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

cezarsa
Copy link
Contributor

@cezarsa cezarsa commented Nov 6, 2023

This PR adds a new parameter to the Slack service to allow disabling link unfurl. By default, Slack will try to unfurl links present in the notification message. However, in most cases, this is not useful as Argo URLs are usually private and inaccessible from Slack servers.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7b19d2c) 55.16% compared to head (29ba9ce) 55.08%.
Report is 1 commits behind head on master.

❗ Current head 29ba9ce differs from pull request most recent head bbfca43. Consider uploading reports for the commit bbfca43 to get more accurate results

Files Patch % Lines
pkg/services/slack.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   55.16%   55.08%   -0.08%     
==========================================
  Files          35       35              
  Lines        3350     3340      -10     
==========================================
- Hits         1848     1840       -8     
+ Misses       1233     1232       -1     
+ Partials      269      268       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh pasha-codefresh merged commit 444b55c into argoproj:master Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants