feat: Update aws-sdk-go-v2 for EKS Pod Identities #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 55.13% 55.19% +0.05%
==========================================
Files 35 35
Lines 3337 3339 +2
==========================================
+ Hits 1840 1843 +3
+ Misses 1230 1229 -1
Partials 267 267 ☔ View full report in Codecov by Sentry. |
14 tasks
Signed-off-by: Mathieu Bruneau <[email protected]>
ROunofF
force-pushed
the
update-aws-sdk
branch
from
66ea3ca
to
931711f
Compare
|
Was testing this patch and sqs notifications are failing I tried with and without specifying account/region/endpointUrl It looks like there is a problem with the sdk version, we might need to update more components to latest like |
Signed-off-by: Carlos Santana <[email protected]>
ROunofF
force-pushed
the
update-aws-sdk
branch
from
7a76f53
to
931711f
Compare
update aws sdk for sqs
Signed-off-by: Carlos Santana <[email protected]>
Signed-off-by: Carlos Santana <[email protected]>
Update aws sdk
Signed-off-by: Carlos Santana <[email protected]>
Fix code coverage for awssqs
|
@todaywasawesome @crenshaw-dev would you be kind to review this PR? 🙏 |
crenshaw-dev
changed the title
crenshaw-dev
approved these changes
Jan 26, 2024
|
Thank you @crenshaw-dev 🎉 |
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update aws-sdk-go-v2 to support EKS Pod Identities
Will update the indirect in argoproj/argo-cd#16641