Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Support GitHub transient environment deployment type #260

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

ricky-sb
Copy link
Contributor

Many people use ArgoCD for preview deployments. GitHub announced transient environments a while back.

We've added a new transient_environment field to allow you to communicate that an environment is specific to a deployment and will no longer exist at some point in the future (e.g. a temporary testing environment like a Heroku Review App).

This PR adds support for that field.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7b19d2c) 55.16% compared to head (2eab075) 55.08%.

❗ Current head 2eab075 differs from pull request most recent head cf764e3. Consider uploading reports for the commit cf764e3 to get more accurate results

Files Patch % Lines
pkg/services/github.go 18.18% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   55.16%   55.08%   -0.09%     
==========================================
  Files          35       35              
  Lines        3350     3344       -6     
==========================================
- Hits         1848     1842       -6     
  Misses       1233     1233              
  Partials      269      269              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricky-sb
Copy link
Contributor Author

Linter is unhappy but once we merge in #257 we should be good!

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pasha-codefresh pasha-codefresh merged commit 9f3e875 into argoproj:master Feb 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants