Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use real cm name instead of placeholder #264

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

dosmanak
Copy link
Contributor

@dosmanak dosmanak commented Feb 5, 2024

Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakepettersson
Copy link
Member

@dosmanak you'll need to signoff your commit(s)

Copy link

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending commit signoffs...

@dosmanak
Copy link
Contributor Author

dosmanak commented Feb 6, 2024

Hi. I signed off the DCO. Thanks for approval. When merged I will regenerate the docs in related PR argoproj/argo-cd#17002

@gdsoumya gdsoumya merged commit 2daee60 into argoproj:master Feb 6, 2024
3 checks passed
@gdsoumya
Copy link
Member

gdsoumya commented Feb 6, 2024

@dosmanak merged this PR, hopefully now the argocd PR would be fixed.

@dosmanak dosmanak deleted the notif_example_cm_name branch February 6, 2024 19:37
@kzap
Copy link

kzap commented Feb 21, 2024

These docs also get merged into argo-rollouts .... Would have preferred they were more agnostic and the replacing of strings be done when they are imported into argo-cd docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants