Add get_city_name() method to dataloader, to fetch name of city where a log was captured.
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senselessdev1
changed the title
get_cityname() method to dataloader, to fetch name of city where a log was captured.get_city_name() method to dataloader, to fetch name of city where a log was captured.
| RuntimeError: If no vector map file is found for the query log ID. | ||
| """ | ||
| vector_map_fpaths = list(self._data_dir.glob(f"{log_id}/map/log_map_archive*")) | ||
| if len(vector_map_fpaths) != 1: |
There was a problem hiding this comment.
Could we add a check for if there's an extra vector map file in the directory?
There was a problem hiding this comment.
@benjaminrwilson thanks for the review. I think this logic is checking for that case already, right?
There was a problem hiding this comment.
Yeah, for sure --- the string for the RuntimeError would be a little misleading in that case though, right?
There was a problem hiding this comment.
Good point. I changed the check to == 0 now, which I think is the more intuitive case (the log is not present).
wqi
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add
get_city_name()method to dataloader, to fetch name of city where a log was captured. Works for TbV, Sensor, or LIDAR datasets.Testing
In order to ensure this PR works as intended, it is:
Compliance with Standards
As the author, I certify that this PR conforms to the following standards: