Cleanup memory pipeline for SuperNova #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winston-h-zhang
changed the title
adr1anh
previously approved these changes
Jan 4, 2024
src/supernova/mod.rs
Outdated
Comment on lines
618
to
632
| // find the largest length r1cs shape for the buffer size | ||
| let mut max_r1cs_primary = &pp[0].r1cs_shape; | ||
| pp.circuit_shapes.iter().for_each(|circuit| { | ||
| if circuit.r1cs_shape.num_cons > max_r1cs_primary.num_cons { | ||
| max_r1cs_primary = &circuit.r1cs_shape; | ||
| } | ||
| }); | ||
|
|
||
| let buffer_primary = ResourceBuffer { | ||
| l_w: None, | ||
| l_u: None, | ||
| ABC_Z_1: R1CSResult::default(max_r1cs_primary), | ||
| ABC_Z_2: R1CSResult::default(max_r1cs_primary), | ||
| T: r1cs::default_T(max_r1cs_primary), | ||
| }; |
There was a problem hiding this comment.
R1CSResult::default() only requires the num_cons value from the R1CSShape. If we change the function to take this value instead, then we can more simply compute
let max_num_cons = *pp.circuit_shapes.iter().map(|shape| shape.num_cons).max().unwrap();
let buffer_primary = ResourceBuffer {
l_w: None,
l_u: None,
ABC_Z_1: R1CSResult::default(max_num_cons),
ABC_Z_2: R1CSResult::default(max_num_cons),
T: r1cs::default_T(max_num_cons),
}; 
winston-h-zhang
force-pushed
the
sn-spmvm-allocations
branch
from
f2d0d71
to
ba6e6dc
Compare
huitseeker
approved these changes
Jan 4, 2024
5 tasks
huitseeker
added a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 14, 2024
* Small perf items (argumentcomputer#12) * Optimize generator creation in provider module - Refactored the `from_label` function in pasta.rs removing redundant collect, flatten operations and Vec<usize> creation, * fix: rename VanillaRO -> NativeRO * refactor: Optimize circuit methods and enhance trait compatibility - Replaced the `.map()` function with the `.map_or()` function in `r1cs.rs` for efficiency. - Added `Eq` trait derivation to `NovaAugmentedCircuitParams` in `circuit.rs` to enable comparisons. - Introduced `Eq` trait to `TrivialTestCircuit` struct in `traits/circuit.rs` without altering its input or output. - Optimized performance by refactoring the use of iterator `into_iter()` to the iterator itself in `gadgets/r1cs.rs`. * ci: Bring clippy standards lurk-rs -> arecibo (argumentcomputer#13) * ci: Bring clippy standards lurk-rs -> arecibo - Added a new .cargo/config file with a custom alias "xclippy" to execute Clippy lints for code quality assurance, - Fixed code correspondingly when necessary, - Added xclippy to CI * chore: add dbg_macro to ci's clippy - Implemented a new clippy lint for the dbg_macro in the cargo config file * test: Extend tests to add missing curve variants (argumentcomputer#33) - Enhanced testing for multiple modules, including bellpepper, spartan, and provider, focusing on the addition and multiplication of multi-linear polynomials and the Keccak transcript. - Introduced usage of secp256k1::Scalar (and sometimes bn256_grumpkin::bn256::Scalar) into tests for improved coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the next step of #137.
This PR brings the changes done to the Nova memory pipeline in #139, #143, and #144 to SuperNova as well. Since the core logic was already established in the previous Nova PRs, this PR mostly just refactors and cleans up the SuperNova API.
Notes:
R1CSShape::multiply_vec, since it's still in(pp)snark.rs. The concatenation ofz = W.W ++ U.u ++ U.Xhappens anyways, so we can keep the instances ofS.multiply_vec(z)for readability.