-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add benchmarks for loaded params #915
Conversation
!gpu-benchmark |
275647e
to
4cae4ab
Compare
Benchmark for 3b9c434Click to view benchmark
|
4cae4ab
to
a6fe23f
Compare
!gpu-benchmark |
Benchmark for 3b9c434Click to view benchmark
|
The strangest thing is that there seems to be no slowdown on this GPU with loaded params. |
I'm concerned about the increase in cost for this benchmark. Can we measure it in another place? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of our benchmark machines are configured to not let the application write anything to disk, and do so without letting it fail to read or write. The bench machines send the bytes to /dev/null
and successfully read zero-sized files.
(for more details : https://github.com/abbbi/nullfsvfs )
As a consequence, modifying the fibonacci benchmark is not a good way to test for public parameter loading.
Ah, thank you for the heads up. That explains the absence of any slowdown, then. I guess I'll have to manually test any loading-related regressions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this in request changes for clarity.
7abc39a
to
059ecad
Compare
059ecad
to
8a83b02
Compare
Closed after argumentcomputer/arecibo#137 |
This PR adjusts the
fibonacci
bench to also test loaded params. In the benchmark, we first test with a set of freshly generated params, writing them to disk if necessary, and then we test again with a loaded set of params.