Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: mousescroll on TimePicker, fade flickering #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

storeman
Copy link

See also: #84

@arian
Copy link
Owner

arian commented Nov 15, 2011

What's the issue with the timepicker in firefox? #84 is fixed now.

@storeman
Copy link
Author

When scrolling on the hour-field or minutes-field, the whole window scrolls because the event.stop() doesn't work as expected.

I think it's due to a change in Firefox, because I've also had this issue when I scroll on an Google Maps canvas on a page. Changing the value in a separate thread seems to fix the problem, but it's not a nice fix.

@olivdee
Copy link

olivdee commented Nov 28, 2012

having the same problem here. in chrome everything is fine, in FF the whole content scrolls. i am using mootools1.4.5 and the current datepicker... @storeman : what to you mean by "Changing the value in a separate thread seems to fix the problem" ... what value, in what thread ???

@storeman
Copy link
Author

@olivdee You can see my work-arounds above. I say threads, because I use a delay to set the value, that solved the problem at that time. But I think that the tween-fix did the trick.

@olivdee
Copy link

olivdee commented Nov 29, 2012

thanks for pointing this out. its my first time at git... the scrolling-error-fix did not, so i tried to implement the tween-fix, but realized that Picker.js has been changed since then. so i am not sure where to apply all your changes. any idea / help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants