Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support an options hash with attributes for the custom tag #31

Closed
arielj opened this issue Aug 31, 2021 · 1 comment
Closed

Support an options hash with attributes for the custom tag #31

arielj opened this issue Aug 31, 2021 · 1 comment

Comments

@arielj
Copy link
Owner

arielj commented Aug 31, 2021

Currently the helpers support a tag option to change the HTML tag but some tags may need some attributes (like a name and value if using a button tag).

Having a tag_attributes key that we pass to the content_tag helper should be enough.
@arielj arielj mentioned this issue Sep 3, 2021
Open
@arielj
Copy link
Owner Author

arielj commented Sep 22, 2021

Done in version 1.4.0

@arielj arielj closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arielj