Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the links are not present in the tabbing order #32

Open
yshmarov opened this issue Sep 3, 2021 · 2 comments
Open

the links are not present in the tabbing order #32

yshmarov opened this issue Sep 3, 2021 · 2 comments

Comments

@yshmarov
Copy link
Contributor

yshmarov commented Sep 3, 2021

something like tabindex="0" should be added to the links so that they can be Tab-bed to. Will add more on this later

@yshmarov

<a role="button" tabindex="0" ...>...

@arielj
Copy link
Owner

arielj commented Sep 3, 2021

hey @yshmarov thanks for the report, I think this other issue would cover that #31, I was thinking about having one more html_attribute hash argument in the link_to_add/remove_nested helpers that can be used to set the HTML attributes of the generated tag, that way we can add role, tabindex, alt, title, etc for the users that need it

Do you think that would cover this feature requrest too?

@arielj
Copy link
Owner

arielj commented Sep 22, 2021

@yshmarov I released version 1.4.0 today, I think it may fix this issue but maybe the tabindex is a more complex use case (all link_to_remove_nested will have the same tabindex for example) but you can now add role and tabindex attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants