Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limit uses the wrong count #8

Closed
arielj opened this issue Feb 20, 2021 · 0 comments · Fixed by #29
Closed

limit uses the wrong count #8

arielj opened this issue Feb 20, 2021 · 0 comments · Fixed by #29

Comments

@arielj
Copy link
Owner

arielj commented Feb 20, 2021 •
edited
Loading

Currently, code checks the container's children length to compare with the limit value:

https://github.com/arielj/vanilla-nested/blob/master/app/assets/javascripts/vanilla_nested.js#L32

But if the container has more children other than the fields wrappers, the count is wrong, triggering the limit reached event.

Ideally, the helper method should get the wrapper class from the partial.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Count only non-destroyed children to emit the limit reached event arielj/vanilla-nested
1 participant
@arielj