Count only non-destroyed children to emit the limit reached event #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was too basic only using the number of children that the wrapper had to calculate if the accepts_nested_attributes_for limit was reached. It was a problem since it was counting destroyed elements and also any other extra html element that was a direct child of the wrapper.
The new implementation counts the number of
[_destroy]
hidden fields with value of0
, that's the correct amount.This closes #8