Add schema parsing for unix scheme urls #2847
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2472
Faced the same issue (altough with atlas migrate) when trying to migrate through a unix socket, seems the issue is here:
Since the url path for unix sockets can contain multiple
/
characters.Steps to reproduce issue (tested on macOS):
There is a function in the go-sql-driver/mysql that could be used to parse the DSN and extract the schema, but didn't want to add another dependency to this repo without approval so kept it simple here!
Feel free to suggest improvements or comments on the code, I don't have all the context of atlas so might have missed something! @ttc0419 could maybe have a look and see if it solved the issue for them as well!